[alsa-devel] [patch 2/3] kirkwood: Add audio support to hp t5325 thin clients

[Mark Brown]

On Tue, Oct 12, 2010 at 11:44:55AM +0200, Arnaud Patard wrote:

> +config SND_KIRKWOOD_SOC_T5325
> +	tristate "SoC Audio support for HP t5325"
> +	#depends on SND_KIRKWOOD_SOC && MACH_T5325

Hrm?

> +	switch (params_rate(params)) {
> +	default:
> +	case 44100:
> +		freq = 11289600;
> +		break;
> +	case 48000:
> +		freq = 12288000;
> +		break;
> +	case 96000:
> +		freq = 24576000;
> +		break;
> +	}

This should have a default: or (better) just be rewritten to use
params_rate(params) * 256 as the sysclk.

> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:soc-audio");

No, you're registering the device here not the driver.