[alsa-devel] [PATCH 1/2] ASoC: fsi: simultaneous playback/recorde support

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Tue Oct 12 11:33:04 CEST 2010


Dear Liam

Thank you for your checking patch

> > +/* is */
> > +#define IS_PLAY		1
> > +#define IS_CAPTURE	0
> 
> Please use SNDRV_PCM_STREAM_PLAYBACK and SNDRV_PCM_STREAM_CAPTURE here.

understand but ...
I think
SNDRV_PCM_STREAM_PLAYBACK = 0
SNDRV_PCM_STREAM_CAPTURE  = 1

But in fsi driver, IS_PLAY needs 1,  IS_CAPTURE needs 0 for now.
should I modify all of these ?

Best regards
--
Kuninori Morimoto
 


More information about the Alsa-devel mailing list