[alsa-devel] [PATCH] add missing comparison to strcmp call

Liam Girdwood lrg at slimlogic.co.uk
Wed Nov 10 14:13:04 CET 2010


On Tue, 2010-11-09 at 15:43 -0600, abraham duenas wrote:
> >From f796e5f464d3454761b618912e5b4d14716c2bfc Mon Sep 17 00:00:00 2001
> From: abraham duenas <abraham.duenas at ti.com>
> Date: Tue, 9 Nov 2010 15:31:16 -0600
> Subject: [PATCH] add missing comparison to strcmp call
> 

Could do with a little more description here.

> 
> Signed-off-by: abraham duenas <abraham.duenas at ti.com>
> ---
>  src/ucm/main.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/ucm/main.c b/src/ucm/main.c
> index e233f41..a73595d 100644
> --- a/src/ucm/main.c
> +++ b/src/ucm/main.c
> @@ -774,9 +774,9 @@ int snd_use_case_get_list(snd_use_case_mgr_t *uc_mgr,
>         pthread_mutex_lock(&uc_mgr->mutex);
>         if (strcmp(identifier, "_verbs") == 0)
>                 err = get_verb_list(uc_mgr, list);
> -        else if (strcmp(identifier, "_enadevs"))
> +        else if (strcmp(identifier, "_enadevs") == 0)
>                 err = get_enabled_device_list(uc_mgr, list);
> -        else if (strcmp(identifier, "_enamods"))
> +        else if (strcmp(identifier, "_enamods") == 0)
>                  err = get_enabled_modifier_list(uc_mgr, list);
>          else {
>                  str1 = strchr(identifier, '/');

Looks fine to me, did this solve all your parsing issues ?

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk



More information about the Alsa-devel mailing list