[alsa-devel] [PATCH] ASoC: Push snd_soc_write() and snd_soc_read() into the source file

[Mark Brown]

On Wed, Nov 03, 2010 at 01:51:48PM +0000, Dimitris Papastamos wrote:
> On Mon, 2010-11-01 at 15:44 -0400, Mark Brown wrote:
> > +unsigned int snd_soc_write(struct snd_soc_codec *codec,
> > +			   unsigned int reg, unsigned int val)
> > +{
> > +	dev_dbg(codec->dev, "write %x = %x\n", reg, val);
> > +	return codec->driver->write(codec, reg, val);
> > +}
> > +EXPORT_SYMBOL_GPL(snd_soc_write);

> This sort of debugging output is already present in soc-cache.c.  I
> guess it should be removed from soc-cache.c since it is duplicated
> across all different write() I/O types.

That's the idea; this is much fewer lines of code and also covers all
the MFDs and whatnot that can't use the soc-cache code for whatever
reasons.