[alsa-devel] [PATCH 1/4] OMAP: mcbsp - add omap_mcbsp_set_dma_op_mode()

[Liam Girdwood]

On Wed, 2010-05-19 at 13:50 +0300, Eduardo Valentin wrote:
> On Tue, May 18, 2010 at 10:13:11PM +0200, Liam Girdwood wrote:
> > This adds a method to set the MCBSP DMA OP mode.
> 
> OK. good. But again, why do you need set dma op mode other than inside mcbsp code?
> 

I think Peter has answered this.

> Right, so, from what I have read briefly, the idea is to remove the user space ability to set the mode and
> let mcbsp clients to do it. What is not clear to me is how mcbsp clients (inside kernel) will determine if they want
> short delay or pm friendly. That usually is bound to upper use case though.
> 

An example would be an ASoC client. The ASoC driver would be configured
either for low latency, low power, etc. by userspace (using formal ALSA
calls) and would be able to configure the mcbsp to match this request.  


> It would be really nice if you improve your patch descriptions.

Sorry, I thought again this was obvious.

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk