[alsa-devel] ASoC: OMAP4: Add support for Earphone speaker

Candelaria Villarreal, Jorge jorge.candelaria at ti.com
Tue May 18 17:41:14 CEST 2010


alsa-devel-bounces at alsa-project.org wrote:
> On Tue, May 18, 2010 at 09:23:56AM -0500, Jorge Eduardo
> Candelaria wrote:
>> Add control to enable earphone driver in TWL6040 codec. This driver
>> is connected to HSDAC Left. 
>> 
>> Also enable earphone speaker in sdp4430 machine driver.
> 
> Please don't merge patches like this - you should patch the machine
> driver separately to the CODEC driver unless required for building.
> This helps reduce merge problems, makes the changelogs easier
> to follow
> and makes it easier to apply patches if there's review issues with
> one part of them. 
> 
>> Signed-off-by: Jorge Eduardo Candelaria <jorge.candelaria at ti.com>
>> Signed-off-by: Margarita Olaya Cabrera <magi.olaya at ti.com>
> 
> Acked-by: Mark Brown <broonie at opensource.wolfsonmicro.com>

I'll split this in two patches and add your Acked-by. Thanks.

> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



More information about the Alsa-devel mailing list