[alsa-devel] [patch -next] asihpi: testing the wrong variable

Dan Carpenter error27 at gmail.com
Fri May 14 16:49:20 CEST 2010


There is a typo here.  We want to test "*dst" not "dst".

Signed-off-by: Dan Carpenter <error27 at gmail.com>

diff --git a/sound/pci/asihpi/hpifunc.c b/sound/pci/asihpi/hpifunc.c
index 254c580..15f0c7e 100644
--- a/sound/pci/asihpi/hpifunc.c
+++ b/sound/pci/asihpi/hpifunc.c
@@ -3279,7 +3279,7 @@ static u16 hpi_entity_alloc_and_copy(struct hpi_entity *src,
 
 	buf_size = hpi_entity_size(src);
 	*dst = kmalloc(buf_size, GFP_KERNEL);
-	if (dst == NULL)
+	if (*dst == NULL)
 		return HPI_ERROR_MEMORY_ALLOC;
 	memcpy(*dst, src, buf_size);
 	return 0;


More information about the Alsa-devel mailing list