[alsa-devel] snd-hda-intel - wallclk patch

[Takashi Iwai]

At Tue, 11 May 2010 10:28:50 +0200 (CEST),
Jaroslav Kysela wrote:
> 
> On Mon, 10 May 2010, Jaroslav Kysela wrote:
> 
> > Hi,
> >
> > 	I would like to ask HDA gurus to check this patch (I will include it 
> > to my tree once acked). The patch uses WALLCLK from HDA chips (marked as 
> > required in the HDA specification) to check for bogus - too early - interrups 
> > which confuses the upper PCM layer (sound skipping issues).
> >
> > 	More details about patch testing on problematic hardware can be found 
> > at:
> >
> > 	https://bugzilla.kernel.org/show_bug.cgi?id=15912
> 
> No objections received, so I pushed this code to my master/devel branches.

Heh, that was quick, I had no time to review :)

The change looks good to me.  Thanks for your fix (and rebasing).

One thing is that you removed bdl_pos_adj=0 check.  This was there
explicitly to avoid the delayed irq handling no matter whether the
value is correct or not.  I guess it's safer to take it back, or
give any other way for user to avoid the delayed irq handling.


thanks,

Takashi