[alsa-devel] [PATCH 2/2] snd-es1968: Make hardware volume buttons an input device (rev2)

[Ville Syrjälä]

On Fri, Apr 23, 2010 at 05:26:43AM -0400, Hans de Goede wrote:
> The hardware volume handling code in essence just detects key presses, and
> then does some hardcoded modification of the master volume based on which key
> is pressed.
> 
> Clearly the right thing to do here is just report these keypresses to
> userspace and let userspace decide what to with them.
> 
> This patch adds a Kconfig option which when enabled reports the volume
> buttons as keypresses using an input device. When enabled this option
> also gets rid of the ugly direct ac97 writes from the tasklet, the ac97lock
> and the need for using a tasklet in general.
> 
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>

Tested-by: Ville Syrjälä <syrjala at sci.fi>

Both SND_ES1968_INPUT=y and SND_ES1968_INPUT=n work fine on my Dell
Inspiron 7000.

-- 
Ville Syrjälä
syrjala at sci.fi
http://www.sci.fi/~syrjala/