[alsa-devel] [PATCHv5 2/2] ASoC: TWL6040: Add twl6040 codec driver

[Olaya, Margarita]

On Saturday, March 13, 2010 5:23 AM  Felipe Balbi wrote: 

> Hi,
> 
> On Fri, 12 Mar 2010 19:52:20 -0600, "Olaya, Margarita"
> <magi.olaya at ti.com> wrote:
>> +/*
>> + * twl6040 register cache & default register settings + */
>> +static const u8 twl6040_reg[TWL6040_CACHEREGNUM] = {
>> +       0x00, /* not used               0x00    */
>> +       0x4B, /* TWL6040_ASICID (ro)    0x01    */
[snip]
> 
> a little comment about what the default values are would be nice.

Most of the codecs only have the register description, not sure if this
is an standard in alsa. Some values are kind of hard to describe briefly.

> 
> #ifdef CONFIG_PM
> 
>> +static int twl6040_suspend(struct platform_device *pdev,
[snip]
> 
> #else
> #define twl6040_suspend    NULL
> #define twl6040_resume     NULL
> #endif

I'll add this.

Regards,
Margarita