[alsa-devel] [PATCH 19/20] ASoC: S3C64XX: IISv4: Add CPU driver

[jassi brar]

On Wed, Mar 10, 2010 at 8:39 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Wed, Mar 10, 2010 at 04:49:08PM +0900, Jassi Brar wrote:
>
>> +static int s3c64xx_i2sv4_probe(struct platform_device *pdev,
>> +                          struct snd_soc_dai *dai)
>> +{
>> +     /* configure GPIO for i2s port */
>> +     s3c_gpio_cfgpin(S3C64XX_GPC(4), S3C64XX_GPC4_I2S_V40_DO0);
>> +     s3c_gpio_cfgpin(S3C64XX_GPC(5), S3C64XX_GPC5_I2S_V40_DO1);
>> +     s3c_gpio_cfgpin(S3C64XX_GPC(7), S3C64XX_GPC7_I2S_V40_DO2);
>> +     s3c_gpio_cfgpin(S3C64XX_GPH(6), S3C64XX_GPH6_I2S_V40_BCLK);
>> +     s3c_gpio_cfgpin(S3C64XX_GPH(7), S3C64XX_GPH7_I2S_V40_CDCLK);
>> +     s3c_gpio_cfgpin(S3C64XX_GPH(8), S3C64XX_GPH8_I2S_V40_LRCLK);
>> +     s3c_gpio_cfgpin(S3C64XX_GPH(9), S3C64XX_GPH9_I2S_V40_DI);
>
> It seems retrograde to add this rather than using the platform data
> callback that you added.  We'll need some arch/arm changes for the
> driver to probe anyway so it't not a big deal to add the dependency.
I know, but that way I would have had to wait on S3C ARCH tree reflect
the patch(for which s3c64xx-i2s.c depends already).
When my latest ARCH patches are visible in your tree, we can easily switch
to using cfg_gpio in both the drivers.