[alsa-devel] Reforming S3C I2S towards supporting I2Sv4

[Liam Girdwood]

On Wed, 2010-03-10 at 16:48 +0900, Jassi Brar wrote:
> Hello,
> 
>  I have prepared some patches that debug and modify the behaviour of
> extant S3C I2S support towards managing I2Sv4 controllers as well.
> 
> Overall pic...
>  For now the 'new' I2Sv4 CPU driver(s3c64xx-i2s-v4.c) is almost a copy
> of s3c64xx-i2s.c The driver will evolve as support for more features is
> added.
>  Minor quirks in otherwise similar controllers are handled by defining
> a new field(feature) in 'struct s3c_i2sv2_info' that is meant to contain
> 1-bit flags for absence/presence of such quirks.

patches 1 - 9 Acked-by: Liam Girdwood <lrg at slimlogic.co.uk>

>  The header with I2S register map and bit definitions has been copied
> to where the drivers are(sound/soc/s3c24xx/) since the header has nothing
> usable for platform code. Also, it will help avoid need for co-ordination
> between ASoC and S3C ARCH trees. For now, the header regs-s3c2412-iis.h
> is left intact but rendered useless by making ASoC drivers include the
> newly copied version of it (sound/soc/s3c24xx/regs-i2s-v2.h) Later the
> header could be dropped by patches to S3C PLAT tree.
> 

I'm not too keen on moving CPU register and bit definitions out of ARCH.

Liam 

-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk