[alsa-devel] [PATCH] ASoC: ak4642: Add Playback Volume control

[Mark Brown]

On Mon, Jun 28, 2010 at 12:07:05PM +0900, Kuninori Morimoto wrote:

> Manual said this register name is "Digital Volume Control".
> In this case, should I use "Digital Playback Volume" ?
> or "Master Playback Volume" ?

Either is fine.

> > +static const DECLARE_TLV_DB_SCALE(out_tlv, -11500, 50, 1);

> Is this -11500 correct ?
> it should be -11550 ?

Should be -11600.  You can check this by using an application like
alsamixer and looking at the dB values displayed in the UI.

> > +static const struct snd_kcontrol_new ak4642_snd_controls[] = {

> > +	SOC_DOUBLE_R_TLV("Playback Volume", L_DVC, R_DVC,
> > +			 0, 0xFF, 1, out_tlv),

> And here, Is 0xFF correct here ?
> Is it 0xFE ?

No, 0xff is still a valid value.