[alsa-devel] [PATCH] ASoC: ak4642: Add Playback Volume control

[Kuninori Morimoto]

Dear Liam

Thanks for checking patch


> > +	SOC_DOUBLE_R_TLV("Playback Volume", L_DVC, R_DVC,
> > +			 0, 0xFF, 1, out_tlv),
> 
> Is this for the "Master Playback Volume" ? If so, It should be "Master
> Playback Volume"

I understand. Thanks
I will send V2 patch

> >  		 * PLL, Master Mode
> >  		 * Audio I/F Format :MSB justified (ADC & DAC)
> > -		 * Digital Volume: -8dB
> 
> Any reason for this ?
> 
> >  		 * Bass Boost Level : Middle
> >  		 *
> >  		 * This operation came from example code of
> > @@ -200,8 +217,6 @@ static int ak4642_dai_startup(struct snd_pcm_substream *substream,
> >  		ak4642_write(codec, 0x0e, 0x19);
> >  		ak4642_write(codec, 0x09, 0x91);
> >  		ak4642_write(codec, 0x0c, 0x91);
> > -		ak4642_write(codec, 0x0a, 0x28);
> > -		ak4642_write(codec, 0x0d, 0x28);
> 
> and this. Both are not mentioned in the commit message.

Sorry. Both are "L_DVC" and "R_DVC". and 0x28 mean -8 dB
I removed it because if ak4642_dai_startup have it,
user can not change Playback Volume.

Best regards
--
Kuninori Morimoto