[alsa-devel] [PATCH 1/1] Daily snapshot not building on 2.6.32

[Takashi Iwai]

At Thu, 24 Jun 2010 08:50:48 -0700,
Brad Figg wrote:
> 
> On 06/24/2010 08:40 AM, Takashi Iwai wrote:
> > At Thu, 24 Jun 2010 08:37:40 -0700,
> > Brad Figg wrote:
> >>
> >> On 06/24/2010 08:35 AM, Takashi Iwai wrote:
> >>> At Thu, 24 Jun 2010 08:27:37 -0700,
> >>> Brad Figg wrote:
> >>>>
> >>>> On 06/24/2010 08:02 AM, Takashi Iwai wrote:
> >>>>> At Thu, 24 Jun 2010 07:56:35 -0700,
> >>>>> Brad Figg wrote:
> >>>>>>
> >>>>>> On 06/23/2010 11:27 PM, Takashi Iwai wrote:
> >>>>>>> At Wed, 23 Jun 2010 11:37:16 -0700,
> >>>>>>> Brad Figg wrote:
> >>>>>>>>
> >>>>>>>> I've had to apply the following patch to successfully build
> >>>>>>>> the daily snapshot on 2.6.32. Without this patch I get:
> >>>>>>>
> >>>>>>> Which tarball?  The latest one works fine for me.
> >>>>>>>
> >>>>>>>
> >>>>>>> Takashi
> >>>>>>
> >>>>>> Today's snapshot is giving me the exact same error.
> >>>>>
> >>>>> Did you get from the URL below, right?
> >>>>>
> >>>>>      ftp://ftp.kernel.org/pub/linux/kernel/people/tiwai/snapshot/alsa-driver-snapshot.tar.gz
> >>>>>
> >>>>> Then check config.log whether usb_alloc_coherent() check worked.
> >>>>>
> >>>>>
> >>>>> Takashi
> >>>>>
> >>>>
> >>>> I'm pulling the snapshot from the correct location. However:
> >>>>         checking usb_alloc_coherent... no
> >>>
> >>> That's correct.  Then it must have
> >>> 	#undef CONFIG_SND_HAVE_USB_ALLOC_COHERENT
> >>> in include/config.h, and incldue/adriver.h should define a wrapper for
> >>> the function.  Please check it.
> >>>
> >>>
> >>> Takashi
> >>
> >> include/config.h:
> >>
> >> /* #undef CONFIG_SND_HAVE_USB_ALLOC_COHERENT */
> >>
> >>
> >>
> >> include/adriver.h:
> >>
> >> #ifndef CONFIG_SND_HAVE_USB_ALLOC_COHERENT
> >> #define usb_alloc_coherent      usb_buffer_alloc
> >> #define usb_free_coherent       usb_buffer_free
> >> #endif
> >
> > Check whether the code patch there reaches while compiling ua101.c.
> >
> >
> > Takashi
> 
> It does not reach that when compiling ua101.c. The reason for the patch in
> the original email was to pick up the SND_NEED_USB_WRAPPER define when
> compiling that file.

Ah, right.  It should include "../usbaudio.inc" instead of "adriver.h".
I fixed this now.


thanks,

Takashi