[alsa-devel] [PATCH v2] codecs/tlv320aic23: fix bias management for suspend/resume

[Liam Girdwood]

On Sat, 2010-06-19 at 19:33 +0200, Eric Bénard wrote:
> in tlv320aic23_set_bias_level, for the case SND_SOC_BIAS_ON, the
> comment says "vref/mid, osc on, dac unmute" but the code doesn't
> clear the corresponding bits, thus when resuming, several bits are
> not cleared preventing the codec from working.
> 
> in tlv320aic23_suspend, clearing the active register is not needed
> as it will be done by tlv320aic23_set_bias_level, when setting
> bias to SND_SOC_BIAS_OFF
> 
> Signed-off-by: Eric Bénard <eric at eukrea.com>
> Cc: broonie at opensource.wolfsonmicro.com
> Cc: anuj.aggarwal at ti.com
> Cc: lrg at slimlogic.co.uk
> ---
> v2:
> 	fix the problem in tlv320aic23_set_bias_level instead of the
> 	previous bad workaround in suspend.
> 
>  sound/soc/codecs/tlv320aic23.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 

Acked-by: Liam Girdwood <lrg at slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk