[alsa-devel] [PATCH 3/4] ALSA: usb-audio: parse UAC2 sample rate ranges correctly

Takashi Iwai tiwai at suse.de
Fri Jun 11 17:54:52 CEST 2010


At Fri, 11 Jun 2010 17:46:33 +0200,
Daniel Mack wrote:
> 
> On Fri, Jun 11, 2010 at 05:43:04PM +0200, Takashi Iwai wrote:
> > At Fri, 11 Jun 2010 17:34:21 +0200,
> > Daniel Mack wrote:
> > > 
> > > +		/*
> > > +		 * for ranges with res == 1, we want a continuous sample
> > > +		 * rate range, so this function should return 0.
> > > +		 */
> > > +		if (res == 1) {
> > > +			fp->rates = SNDRV_PCM_RATE_CONTINUOUS;
> > > +			return 0;
> > 
> > Missing setup of fp->rate_min and fp->rate_max here?
> 
> Gna, not my day. I did that, and of course tested it with a modified
> firmware and it worked well.
> 
> But appearantly I exported the wrong patch. Sorry.

Well, people can understand it if they see the current score of the
opening football game ;)


Takashi


More information about the Alsa-devel mailing list