[alsa-devel] [PATCH v2 1/3]AsoC/nuc900: patch for SUBSTREAM_TYPE', 'PCM_TX' and 'PCM_RX' removal

Wan ZongShun mcuos.com at gmail.com
Wed Jun 2 08:07:29 CEST 2010


I am sorry for wrong subject.
It should be [PATCH v2 1/4].



> This patch is to remove the 'SUBSTREAM_TYPE','PCM_TX' and 'PCM_RX' definition.
>
> There is no need to redefine SNDRV_PCM_STREAM_PLAYBACK as PCM_TX,
> the SUBSTREAM_TYPE(substream) can be deleted too, the playback or record can be
> judged by 'if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)' directly rather
> than 'if (PCM_TX == stype)', which makes the codes easy to read.
>
> Signed-off-by: Wan ZongShun<mcuos.com at gmail.com>
>
> ---
>  sound/soc/nuc900/nuc900-ac97.c  |    6 +++---
>  sound/soc/nuc900/nuc900-auido.h |    4 ----
>  sound/soc/nuc900/nuc900-pcm.c   |   18 ++++++++++--------
>  3 files changed, 13 insertions(+), 15 deletions(-)


More information about the Alsa-devel mailing list