[alsa-devel] [PATCH 2/2]ASoC: multi-component - Fix S5P compile error

Chanwoo Choi cw00.choi at samsung.com
Mon Jul 19 15:17:58 CEST 2010


Mark Brown wrote:
> On Mon, Jul 19, 2010 at 09:45:49PM +0900, Chanwoo Choi wrote:
>> This patch fix compile error on using I2S and WM8994 common code.
> 
> This looks to be two completely separate issues and should have been
> sent as two separate patches, especially this one:
> 
Ok, I will do.

>> -#if defined(CONFIG_CPU_S3C2412) || defined(CONFIG_CPU_S3C2413)
>> +#if defined(CONFIG_CPU_S3C2412) || defined(CONFIG_CPU_S3C2413) \
>> +	|| defined(CONFIG_CPU_S5PV210)
>>  #define S3C_IIS_V2_SUPPORTED
> 
> This is implmenting support for a new CPU, not fixing compile errors,
> and so the commit message is very misleading.
Ok, I will modify the commit message.

Thank you,
Chanwoo Choi


More information about the Alsa-devel mailing list