[alsa-devel] [PATCH 13/15] sound/soc: davinci: check kzalloc() result (typo)

Liam Girdwood lrg at slimlogic.co.uk
Sat Jul 17 19:45:33 CEST 2010


On Fri, 2010-07-16 at 20:16 +0400, Kulikov Vasiliy wrote:
> The code checks 'davinci_vc' after kzalloc() and do not checks
> 'davinci_vcif_dev' that kzalloc() result is assigned to. It seems that
> it is a typo (autocompletion?).
> 
> Signed-off-by: Kulikov Vasiliy <segooon at gmail.com>
> ---
>  sound/soc/davinci/davinci-vcif.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/davinci/davinci-vcif.c b/sound/soc/davinci/davinci-vcif.c
> index 9aa980d..4867853 100644
> --- a/sound/soc/davinci/davinci-vcif.c
> +++ b/sound/soc/davinci/davinci-vcif.c
> @@ -203,7 +203,7 @@ static int davinci_vcif_probe(struct platform_device *pdev)
>  	int ret;
>  
>  	davinci_vcif_dev = kzalloc(sizeof(struct davinci_vcif_dev), GFP_KERNEL);
> -	if (!davinci_vc) {
> +	if (!davinci_vcif_dev) {
>  		dev_dbg(&pdev->dev,
>  			"could not allocate memory for private data\n");
>  		return -ENOMEM;

13,14 & 15

Acked-by: Liam Girdwood <lrg at slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk



More information about the Alsa-devel mailing list