[alsa-devel] [PATCH] ASoC: SAMSUNG: Add Aquila sound driver

[Jassi Brar]

On Fri, Jul 9, 2010 at 10:06 AM, Chanwoo Choi <cw00.choi at samsung.com> wrote:
> Jassi Brar wrote:
>  > The gpio config stuff needs to be removed from the CPU driver. It was pending
>> due to fear of cross-tree merge issues. The platform specific code to do the
>> same is already upstream now.
>
> What is "platform specific code to the same" ?
Have a look at arch/arm/mach-s3c64xx/dev-audio.c which has various
cfg_gpio callback functions.


>> One engineer in my team is already looking into it while testing
>> Liam's multi-codec
>> changes.
>>
>>>> Please try to use the existing sound/soc/s3c24xx/s3c64xx-i2s-v4.c
>> 'try to' is the key word here. The driver is not expected to work rightaway.
>> One might need to make some changes to the CPU driver to just make it
>> work on platforms with very similar IP.
>
> Do you mean that I should implement i2sv5 drvier refer to the
> sound/soc/s3c24xx/s3c64xx-i2s-v4.c after completing cross-tree merge issue?

No.  I mean you should make minimal changes to the existing i2s CPU drivers
to make them just work for your machine. Aquila can exploit more
advanced features
of v4/v5 as they will be implemented in future.
If you don't wanna wait, you may start upgrading the existing drivers
in line with
existing frame work.
Please remember, the goal is towards having as least files as possible
in Samsung ASoC which supporting as many SoCs as possible.
Separate driver for V5 maybe warranted only when we want to implement
a feature that is not supported by v4.