[alsa-devel] [PATCH 2/3] ASoC: AC97: S3C: Add controller driver

[jassi brar]

On Tue, Jan 26, 2010 at 7:53 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Tue, Jan 26, 2010 at 04:32:45PM +0900, jassi brar wrote:
>> On Tue, Jan 26, 2010 at 2:51 PM,  <jassisinghbrar at gmail.com> wrote:
>
> Please delete irrelevant context when replying to mails, it's much
> easier to find the actual new text in the message that way.
ok

>> > +                       /* NOTE: If the codec ouputs just one slot,
>> > +                        * it *seems* our AC97 controller reads the only
>> > +                        * valid slot(if either 3 or 4) for PCM-In.
>> > +                        * For such cases, we record Mono.
>> > +                        */
>> > +                       .channels_min = 1,
>
>>   I would like to remove this anomaly and set channels_min = 2
>
> Why?
This hypothesis was based on wrong observation that AC97 can record stereo-mic
if two slots are marked valid and one of them is 6th.
I decided to remove it after that observation turned out wrong(testing error).
Even though this seems logical, but I have not verified it so I wanted
to remove.

>>  And remove the second DAI_LINK in machine driver.
>
> Again, why?
The wm9713 doesn't support mono capture and AC97 controller
doesn't support stereo MIC capture. So the second dai link
is improper.