[alsa-devel] [PATCHv4 3/7] ASoC: TWL6030: Manual power-up/down sequences

[Olaya, Margarita]

> -----Original Message-----
> From: Liam Girdwood [mailto:lrg at slimlogic.co.uk]
> Sent: Wednesday, February 24, 2010 4:41 AM
> To: Olaya, Margarita
> Cc: alsa-devel at alsa-project.org; linux-omap at vger.kernel.org; broonie at opensource.wolfsonmicro.com
> Subject: Re: [PATCHv4 3/7] ASoC: TWL6030: Manual power-up/down sequences
> 
> On Tue, 2010-02-23 at 18:10 -0600, Olaya, Margarita wrote:
> > From: Misael Lopez Cruz <x0052729 at ti.com>
> >
> > TWL6030 codec device can be powered-up/down through a specific register
> > writes sequence. These sequences can be used when no gpio line is
> > provided for AUDPWRON.
> >
> > When the codec is powered-up in this way, automatic power-down sequence
> > (triggered by thermal shutdown) is not possible.
> >
> > Signed-off-by: Misael Lopez Cruz <x0052729 at ti.com>
> > Signed-off-by: Jorge Eduardo Candelaria <jorge.candelaria at ti.com>
> > Signed-off-by: Margarita Olaya Cabrera <magi.olaya at ti.com>
> > ---
> >  sound/soc/codecs/twl6030.c |  112 ++++++++++++++++++++++++++++++++++++++-----
> >  sound/soc/codecs/twl6030.h |   16 ++++++
> >  2 files changed, 115 insertions(+), 13 deletions(-)
> >
> > diff --git a/sound/soc/codecs/twl6030.c b/sound/soc/codecs/twl6030.c
> > index 8b52aa1..ec838b1 100644
> > --- a/sound/soc/codecs/twl6030.c
> > +++ b/sound/soc/codecs/twl6030.c
> > @@ -244,6 +244,88 @@ static void twl6030_init_vdd_regs(struct snd_soc_codec *codec)
> >  	}
> >  }
> >
> > +/* twl6030 codec manual power-up sequence */
> > +static void twl6030_power_up(struct snd_soc_codec *codec)
> > +{
> > +	u8 ncpctl, ldoctl, lppllctl, accctl;
> > +
> > +	ncpctl = twl6030_read_reg_cache(codec, TWL6030_REG_NCPCTL);
> > +	ldoctl = twl6030_read_reg_cache(codec, TWL6030_REG_LDOCTL);
> > +	lppllctl = twl6030_read_reg_cache(codec, TWL6030_REG_LPPLLCTL);
> > +	accctl = twl6030_read_reg_cache(codec, TWL6030_REG_ACCCTL);
> > +
> > +	/* enable reference system */
> > +	ldoctl |= TWL6030_REFENA;
> > +	twl6030_write(codec, TWL6030_REG_LDOCTL, ldoctl);
> > +	mdelay(10);
> > +	/* enable internal oscillator */
> > +	ldoctl |= TWL6030_OSCENA;
> > +	twl6030_write(codec, TWL6030_REG_LDOCTL, ldoctl);
> > +	udelay(10);
> > +	/* enable high-side ldo */
> > +	ldoctl |= TWL6030_HSLDOENA;
> > +	twl6030_write(codec, TWL6030_REG_LDOCTL, ldoctl);
> > +	udelay(244);
> > +	/* enable negative charge pump */
> > +	ncpctl |= TWL6030_NCPENA | TWL6030_NCPOPEN;
> > +	twl6030_write(codec, TWL6030_REG_NCPCTL, ncpctl);
> > +	udelay(488);
> > +	/* enable low-side ldo */
> > +	ldoctl |= TWL6030_LSLDOENA;
> > +	twl6030_write(codec, TWL6030_REG_LDOCTL, ldoctl);
> > +	udelay(244);
> > +	/* enable low-power pll */
> > +	lppllctl |= TWL6030_LPLLENA;
> > +	twl6030_write(codec, TWL6030_REG_LPPLLCTL, lppllctl);
> > +	/* reset state machine */
> > +	accctl |= TWL6030_RESETSPLIT;
> > +	twl6030_write(codec, TWL6030_REG_ACCCTL, accctl);
> > +	mdelay(5);
> > +	accctl &= ~TWL6030_RESETSPLIT;
> > +	twl6030_write(codec, TWL6030_REG_ACCCTL, accctl);
> > +	/* disable internal oscillator */
> > +	ldoctl &= ~TWL6030_OSCENA;
> > +	twl6030_write(codec, TWL6030_REG_LDOCTL, ldoctl);
> > +}
> > +
> > +/* twl6030 codec manual power-down sequence */
> > +static void twl6030_power_down(struct snd_soc_codec *codec)
> > +{
> > +	u8 ncpctl, ldoctl, lppllctl, accctl;
> > +
> > +	ncpctl = twl6030_read_reg_cache(codec, TWL6030_REG_NCPCTL);
> > +	ldoctl = twl6030_read_reg_cache(codec, TWL6030_REG_LDOCTL);
> > +	lppllctl = twl6030_read_reg_cache(codec, TWL6030_REG_LPPLLCTL);
> > +	accctl = twl6030_read_reg_cache(codec, TWL6030_REG_ACCCTL);
> > +
> > +	/* enable internal oscillator */
> > +	ldoctl |= TWL6030_OSCENA;
> > +	twl6030_write(codec, TWL6030_REG_LDOCTL, ldoctl);
> > +	udelay(10);
> > +	/* disable low-power pll */
> > +	lppllctl &= ~TWL6030_LPLLENA;
> > +	twl6030_write(codec, TWL6030_REG_LPPLLCTL, lppllctl);
> > +	/* disable low-side ldo */
> > +	ldoctl &= ~TWL6030_LSLDOENA;
> > +	twl6030_write(codec, TWL6030_REG_LDOCTL, ldoctl);
> > +	udelay(244);
> > +	/* disable negative charge pump */
> > +	ncpctl &= ~(TWL6030_NCPENA | TWL6030_NCPOPEN);
> > +	twl6030_write(codec, TWL6030_REG_NCPCTL, ncpctl);
> > +	udelay(488);
> > +	/* disable high-side ldo */
> > +	ldoctl &= ~TWL6030_HSLDOENA;
> > +	twl6030_write(codec, TWL6030_REG_LDOCTL, ldoctl);
> > +	udelay(244);
> > +	/* disable internal oscillator */
> > +	ldoctl &= ~TWL6030_OSCENA;
> > +	twl6030_write(codec, TWL6030_REG_LDOCTL, ldoctl);
> > +	/* disable reference system */
> > +	ldoctl &= ~TWL6030_REFENA;
> > +	twl6030_write(codec, TWL6030_REG_LDOCTL, ldoctl);
> > +	mdelay(10);
> > +}
> > +
> >  /*
> 
> 
> Some large mdelays here again.
> 
> Liam

Ok, I'll verify and change them.

- Margarita
> 
> --
> Freelance Developer, SlimLogic Ltd
> ASoC and Voltage Regulator Maintainer.
> http://www.slimlogic.co.uk