[alsa-devel] [PATCH v3 1/3] ASoC: OMAP: data_type and sync_mode configurable in audio dma

[Jarkko Nikula]

On Fri, 19 Feb 2010 10:35:25 +0000
Liam Girdwood <lrg at slimlogic.co.uk> wrote:

> > @@ -156,11 +158,7 @@ static int omap_pcm_prepare(struct snd_pcm_substream *substream)
> >  		return 0;
> >  
> >  	memset(&dma_params, 0, sizeof(dma_params));
> > -	/*
> > -	 * Note: Regardless of interface data formats supported by OMAP McBSP
> > -	 * or EAC blocks, internal representation is always fixed 16-bit/sample
> > -	 */
> 
> Perhaps this should be rewritten to reflect mcbsp and mcpdm users rather
> than deleted.
> 
I'm fine with the deletion. AFAIK there is no public specs for the EAC
(at least not for the OMAP2420) so I see this comment only confusing
(I wrote it) and a person who would write DAI driver for the EAC most
probably has accesses to the specs.


-- 
Jarkko