[alsa-devel] Getting pcm_usb_stream plugin to know its limits. [Kind of SOLVED]

[Michaël Cadilhac]

Takashi Iwai <tiwai at suse.de> writes:

> At Mon, 11 Jan 2010 13:35:19 -0500,
> Michaël Cadilhac wrote:
>> 
>> michael at cadilhac.name (Michaël Cadilhac) writes:
>> 
>> > michael at cadilhac.name (Michaël Cadilhac) writes:
>> >
>> >> So, my final saying is the following patch.  It fixes the segfault on
>> >> stopping a non-started usb_stream, plus it adds the ability to set a
>> >> period size and sound rate.  The latter offers a workaround for the
>> >> second issue I came with (that the default values for period bytes, and
>> >> hence period size, were too high for us122l to work).
>> >
>> > Any comment on that patch would be greatly appreciated.  I'm just
>> > wondering if it's safe for me to give it to some people.
>> 
>> Anyone?  Note that this also fixes a real bug, so it might be of
>> interest to include it in the trunk.
>
> Through a quick glance, the patch looks OK to me.
> Could you give a proper subject and changelog to merge your patch
> to git tree?

Hi there Takashi, and sorry for the delay.  Here are the patch,
subdivised in two distinct logical changes.  I hope the format is what
you asked for.

	* usb_stream/pcm_usb_stream.c (snd_pcm_us_stop): Prevent
	dereferencing when structure is not initialized.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 00fix-deref.patch
Type: text/x-patch
Size: 813 bytes
Desc: not available
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20100202/94a78d72/attachment-0002.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01add-tweaking.patch
Type: text/x-patch
Size: 3185 bytes
Desc: not available
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20100202/94a78d72/attachment-0003.patch 
-------------- next part --------------

  I can write the according documentation, if needed.

  Have a great day.

-- 
Michaël `Micha' Cadilhac (LITQ, U. de Montréal) -- http://michael.cadilhac.name
	||   This .sig has been generated by Outlook Express 98
	||        $@(%@#%$*@(#)%$!%)(%$#(@#$%**!@#$+!#?%
	||  and triple-checked on Windows Mail Vista.