[alsa-devel] [PATCH 10/10] sound/soc/blackfin: Fix continuation line formats
Joe Perches
joe at perches.com
Mon Feb 1 18:08:00 CET 2010
On Mon, 2010-02-01 at 14:47 +0000, Mark Brown wrote:
> On Sun, Jan 31, 2010 at 12:02:12PM -0800, Joe Perches wrote:
> > String constants that are continued on subsequent lines with \
> > are not good.
> >
> > Signed-off-by: Joe Perches <joe at perches.com>
>
> Gah, I thought I'd caught most of these when reviewing. If you're using
> a script to pick this stuff up it'd be worth checking for extraneous
> continuations in the middle of code - outside of macros there's little
> call for it.
>
> Applied, thanks.
There are a few false positives and probably a few missing using
grep -rP --include=*.[ch] '".*\\$' * | \
awk '{ if ((gsub("\"", "\"") % 2) == 1) print $0; }'
Most of the uses are __asm__ __volatile__ which could be
considered unsightly but don't impact logging messages.
The rest could/should be fixed.
More information about the Alsa-devel
mailing list