[alsa-devel] [PATCH] ASoC: mcbsp: Add McBSP support for OMAP4

[peter.ujfalusi at nokia.com]

Hi,

It seams that I have really bad mail issues..
I just received the RE mails to the patch, but not the original, so
I picked this mail to reply.
And going to top post :(

In the patch:
@@ -623,6 +652,9 @@ static int omap_mcbsp_dai_set_dai_sysclk(struct snd_soc_dai *cpu_dai,
                if (cpu_class_is_omap1()) {
                        err = -EINVAL;
                        break;
+               } else if (cpu_is_omap44xx()) {
+                       regs->srgr2     &= ~CLKSM;

There's no need to clear the CLKSM, since it is by default not set.
IMHO you shall handle the OMAP4 in a same way as we handle OMAP3.
By doing nothing here.

+                       break;
                }
                err = omap2_mcbsp_set_clks_src(mcbsp_data->bus_id,
                                               MCBSP_CLKS_PRCM_SRC);


Otherwise:
Acked-by: Peter Ujfalusi <peter.ujfalusi at nokia.com>

______________________________________
From: alsa-devel-bounces at alsa-project.org [alsa-devel-bounces at alsa-project.org] on behalf of ext Liam Girdwood [lrg at slimlogic.co.uk]
Sent: Tuesday, December 21, 2010 12:17
To: Jarkko Nikula
Cc: Olaya, Margarita; alsa-devel at alsa-project.org; Mark Brown
Subject: Re: [alsa-devel] [PATCH] ASoC: mcbsp: Add McBSP support for OMAP4

On Tue, 2010-12-21 at 11:48 +0200, Jarkko Nikula wrote:
> On Mon, 20 Dec 2010 17:36:13 +0000
> Mark Brown <broonie at opensource.wolfsonmicro.com> wrote:
>
> > On Mon, Dec 20, 2010 at 11:32:47AM -0600, Olaya, Margarita wrote:
> > > From: Jorge Eduardo Candelaria <jorge.candelaria at ti.com>
> > >
> > > This patch adds McBSP support for the OMAP4 CPU
> >
> > Acked-by: Mark Brown <broonie at opensource.wolfsonmicro.com>
>
> Have my ack too
> Acked-by: Jarkko Nikula <jhnikula at gmail.com>
>
> Out of curiosity: can the McBSP interface to be used as a simple
> alternative to OMAP4 ABE centric audio on existing platfroms like Panda?
>

McBSP, McPDM and DMIC can all be used without the ABE in legacy mode on
OMAP4.

Liam

--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk