[alsa-devel] [PATCH 4/4] ASoC: clean up cache accesser

[Takashi Iwai]

At Mon, 20 Dec 2010 17:09:00 +0000,
Dimitris Papastamos wrote:
> 
> On Mon, 2010-12-20 at 16:54 +0000, Mark Brown wrote:
> > On Mon, Dec 20, 2010 at 05:47:13PM +0100, Takashi Iwai wrote:
> > 
> > > Yes, this would be safer.  I didn't put it since I wasn't sure whether
> > > BUG() content is also expanded at each caller.  If yes, it would
> > > bloat.   (Alternatively we may use snd_BUG_ON() -- it's built in only
> > > when CONFIG_SND_DEBUG is set.)
> > 
> > That's entirely up to the compiler - inline is purely advice and may
> > well be completely ignored by the compile (and of course functions that 
> > aren't marked inline may be inlined if it decides that's useful).
> 
> One way to enforce the expansion of inline functions on gcc is to use
> __attribute__ ((always_inline)).  Generally it is best left up to the
> compiler to perform the inling if it so deems necessary.

Right.  I removed inline in the revised patch.


Takashi