[alsa-devel] [RFC 2.6.38] ASoC: Fix bias power down of non-DAPM codec

Mark Brown broonie at opensource.wolfsonmicro.com
Fri Dec 10 18:42:27 CET 2010


On Fri, Dec 10, 2010 at 06:23:41PM +0200, Jarkko Nikula wrote:
> Currently bias of non-DAPM codec will be powered down (standby/off) whenever
> there is a stream stop. This is wrong in simultaneous playback/capture since
> the bias is put down immediately after stopping the first stream.
> 
> Fix this by using the codec->active count when figuring out the needed bias
> level after stream stop.
> 
> Signed-off-by: Jarkko Nikula <jhnikula at gmail.com>
> ---
> RFC since does this look a valid fix and how to deal with 2.6.37? I think
> patching the .37 first will result in bisect build errors in mainline when
> later merging upcoming .38 changes. Would it be better to patch .37 after
> it's released?

Better to get a patch in there first, then deal with the merge up to
2.6.38.  Stuff like this really does make me think we should just make
DAPM mandatory.  I should have some time to look at this very soon.


More information about the Alsa-devel mailing list