[alsa-devel] [PATCH] ASoC: dapm: Add speaker driver widget.

[Liam Girdwood]

On Mon, 2010-12-06 at 23:38 +0000, Mark Brown wrote:
> On 6 Dec 2010, at 23:30, Liam Girdwood wrote:
> > On Mon, 2010-12-06 at 23:09 +0000, Mark Brown wrote:
> >> 
> 
> >> Sure, but it's fulfiling the same role in the system - it's just that
> >> these days a lot more CODECs are pulling speaker drivers directly into
> >> the CODEC die.  Mostly these have worked well handled as PGAs so it's
> >> not been an issue.
> 
> > In this case as we need to enable the PGA before the driver and disable
> > the driver before the PGA for pop reduction. Hence the current ordering
> > needs an addition/refactoring to deal with the newer generation of
> > CODECs here.
> 
> Well, what I'm saying is that...
> 
> >> I'd certainly expect to see it handled the same way from a DAPM
> >> sequencing point of view as it's fulfilling the same role in the system
> >> (so in the same slot rather than separately as the patch was doing).  Do
> >> we just need to refactor the existing external widgets to be able to
> >> exist in either register or GPIO based versions?
> 
> ...we don't need to change the ordering at all, we've already got a
> sequence point for this sort of widget we can use. We should just make
> the existing speaker and headphone widgets be in terms of one, I think.
> 

The only minor problem here is that the current sequence point is name
"snd_soc_dapm_spk" which would seem confusing to haptic/vibra driver
users. Although, I can live with this....

Liam