[alsa-devel] [PATCH - 1/1] patch_nvhdmi.c: Add missing codec IDs, unify names

[Stephen Warren]

Takashi Iwai wrote:
> 
> At Mon,  9 Aug 2010 22:41:40 -0600,
> Stephen Warren wrote:
> >
> > * Add missing codec IDs.
> > * Modify some existing codec names for discrete GPUs to match newly
> >   added IDs. Note: existing names were a mixture of marketing and
> >   engineering GPU names. Equally, there's no reason that codec IDs
> >   have to be specific to a particular GPU or board, so identify
> >   codecs in a less marketing-oriented fashion.
> > * Reformat codec ID table so it's easier to read, for me at least.
> >
> > Signed-off-by: Stephen Warren <swarren at nvidia.com>
> 
> Applied now as is.  It doesn't exceed too much over 80 columns ;)

Does such a change automatically go into previous stable kernels as well as the
current development kernel? Or, do I/you need to specifically request this? I'm
hoping to get the patches for this and the previous old_pin_detect fix widely
distributed to solve the issues some end-users are seeing.

I guess this is a little moot, since many distros seem to update the ALSA
driver directly, rather than using the version in the kernel they build.

Related, one end-user asked when the alsa-lib patches to expose N HDMI PCMs per
GPU would be available in distros. Does alsa-lib make scheduled releases, so
I could predict when the current git would be picked up by a distro?

Thanks.

> > diff --git a/pci/hda/patch_nvhdmi.c b/pci/hda/patch_nvhdmi.c
> > index a281836..77e2b40 100644
> > --- a/pci/hda/patch_nvhdmi.c
> > +++ b/pci/hda/patch_nvhdmi.c
> > @@ -540,26 +540,32 @@ static int patch_nvhdmi_2ch(struct hda_codec *codec)
> >   * patch entries
> >   */
> >  static struct hda_codec_preset snd_hda_preset_nvhdmi[] = {
> > ...
> > +	{ .id = 0x10de0002, .name = "MCP77/78 HDMI",  .patch = patch_nvhdmi_8ch_7x },
> > +	{ .id = 0x10de0003, .name = "MCP77/78 HDMI",  .patch = patch_nvhdmi_8ch_7x },
> > +	{ .id = 0x10de0005, .name = "MCP77/78 HDMI",  .patch = patch_nvhdmi_8ch_7x },
> > +	{ .id = 0x10de0006, .name = "MCP77/78 HDMI",  .patch = patch_nvhdmi_8ch_7x },
> > +	{ .id = 0x10de0007, .name = "MCP79/7A HDMI",  .patch = patch_nvhdmi_8ch_7x },
> > +	{ .id = 0x10de000a, .name = "GPU 0a HDMI/DP", .patch = patch_nvhdmi_8ch_89 },
> > +	{ .id = 0x10de000b, .name = "GPU 0b HDMI/DP", .patch = patch_nvhdmi_8ch_89 },
> > +	{ .id = 0x10de000c, .name = "MCP89 HDMI",     .patch = patch_nvhdmi_8ch_89 },
> > +	{ .id = 0x10de000d, .name = "GPU 0d HDMI/DP", .patch = patch_nvhdmi_8ch_89 },
> > +	{ .id = 0x10de0010, .name = "GPU 10 HDMI/DP", .patch = patch_nvhdmi_8ch_89 },
> > +	{ .id = 0x10de0011, .name = "GPU 11 HDMI/DP", .patch = patch_nvhdmi_8ch_89 },
> > +	{ .id = 0x10de0012, .name = "GPU 12 HDMI/DP", .patch = patch_nvhdmi_8ch_89 },
> > +	{ .id = 0x10de0013, .name = "GPU 13 HDMI/DP", .patch = patch_nvhdmi_8ch_89 },
> > +	{ .id = 0x10de0014, .name = "GPU 14 HDMI/DP", .patch = patch_nvhdmi_8ch_89 },
> > +	{ .id = 0x10de0018, .name = "GPU 18 HDMI/DP", .patch = patch_nvhdmi_8ch_89 },
> > +	{ .id = 0x10de0019, .name = "GPU 19 HDMI/DP", .patch = patch_nvhdmi_8ch_89 },
> > +	{ .id = 0x10de001a, .name = "GPU 1a HDMI/DP", .patch = patch_nvhdmi_8ch_89 },
> > +	{ .id = 0x10de001b, .name = "GPU 1b HDMI/DP", .patch = patch_nvhdmi_8ch_89 },
> > +	{ .id = 0x10de001c, .name = "GPU 1c HDMI/DP", .patch = patch_nvhdmi_8ch_89 },
> > ...

-- 
nvpublic