[alsa-devel] [PATCH] ASoC: Fix tlv320aic3x GPIO initialization

Jarkko Nikula jhnikula at gmail.com
Mon Aug 23 09:38:40 CEST 2010


aic3x_init does a soft reset first and thus TLV320AIC3x GPIO setup must be
done after doing the basic init. Before multi-component the init was done
at i2c probe time and GPIO setup at soc probe time.

Signed-off-by: Jarkko Nikula <jhnikula at gmail.com>
Acked-by: Mark Brown <broonie at opensource.wolfsonmicro.com>
---
This got lost during multi-component work. Now rebased on recent aix3x
changes so that applies with git am. I took freedom to add Mark's acked-by,
see:
http://mailman.alsa-project.org/pipermail/alsa-devel/2010-August/030278.html
---
 sound/soc/codecs/tlv320aic3x.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
index c074657..efae8b5 100644
--- a/sound/soc/codecs/tlv320aic3x.c
+++ b/sound/soc/codecs/tlv320aic3x.c
@@ -1281,6 +1281,8 @@ static int aic3x_probe(struct snd_soc_codec *codec)
 	codec->hw_write = (hw_write_t) i2c_master_send;
 	codec->control_data = aic3x->control_data;
 
+	aic3x_init(codec);
+
 	if (aic3x->setup) {
 		/* setup GPIO functions */
 		aic3x_write(codec, AIC3X_GPIO1_REG,
@@ -1289,8 +1291,6 @@ static int aic3x_probe(struct snd_soc_codec *codec)
 			    (aic3x->setup->gpio_func[1] & 0xf) << 4);
 	}
 
-	aic3x_init(codec);
-
 	snd_soc_add_controls(codec, aic3x_snd_controls,
 			     ARRAY_SIZE(aic3x_snd_controls));
 	if (aic3x->model == AIC3X_MODEL_3007)
-- 
1.7.1



More information about the Alsa-devel mailing list