[alsa-devel] [PATCH v2] Add support for tlv320aic3007 to tlv320aic3x codec.

[Mark Brown]

On Fri, Aug 20, 2010 at 12:47:53PM +0800, Randolph Chung wrote:
> This patch adds support for the tlv320aic3007 codec to the tlv320aic3x
> driver.
> 
> The tlv320aic3007 is similar to the aic31, but has an additional class-D
> speaker amp. The speaker amp control register overlaps with the mono
> output register of other codecs in this family, so we add logic to
> identify the actual codec being registered to set things up accordingly.

Applied but...

> +static const struct i2c_device_id aic3x_i2c_id[] = {
> +	[AIC3X_MODEL_3X] = { "tlv320aic3x", 0 },
> +	[AIC3X_MODEL_33] = { "tlv320aic33", 0 },
> +	[AIC3X_MODEL_3007] = { "tlv320aic3007", 0 },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(i2c, aic3x_i2c_id);

The more idiomatic way to write this stuff is:

	{ "tlv320aic3007", AIC3X_MODEL_3007 }

and then look at the id field in the probe() function.  Could you send a
followup patch doing that, please?