[alsa-devel] [PATCH] Show processing coefficients in codec proc file

[David Henningsson]

2010-08-19 20:28, Takashi Iwai skrev:
> At Thu, 19 Aug 2010 20:17:42 +0200,
> David Henningsson wrote:
>>
>> This patch is helpful for tracking down bugs without having all
>> information about the chip.
> 
> I don't want to change coef index in reading a proc file in general.

Good point. But I think the solution to that problem would be to
- read current index
- do the loop
- restore current index

...and perhaps protect that with an appropriate mutex (which one)?

> If any, you should implement a codec-specific hook.

I'm sorry, but I don't really see how that would help...?

Another option would be to have a generic snd_hda_codec_write_coef(nid,
index, value) and snd_hda_codec_read_coef(nid, index) in hda_codec.c
(and perhaps protect it with a spin lock?), then remove all other code
that directly sets the coefficient index.

-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic