[alsa-devel] [PATCH] ASoC/multi-component: fix au1x platform

[Manuel Lauss]

Hi Mark,

On Thu, Aug 19, 2010 at 4:06 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On Thu, Aug 19, 2010 at 03:21:35PM +0200, Manuel Lauss wrote:
>
>> Attached is a patch which fixes the Alchemy (au1x) audio platform
>> in your "topic/multi-component" branch.
>
> I would provide more detailed review but you've attached your patch as a
> base64 encoded attachment rather than including it inline so my MUA
> hasn't quoted it.
>
> As far as your comments about multiple cards go this should now be
> supported, though the fact that you're modifying the static data for the
> DAI means that the aux1x drivers probably don't support this or only
> support it in a limited fashion.

The hardware does support it with the issue you mentioned fixed, but the
global "soc_ac97_ops" needs to go away first.  The alchemy line can
support up to 4 independent ac97 "cards" with certain models.


> Your kobject_name() stuff looks pretty fishy - is there some reason for
> not using dev_name()?

no reason, I'll change it.

Thanks,
      Manuel Lauss
--
To unsubscribe from this list: send the line "unsubscribe alsa-devel" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html