[alsa-devel] [PATCH 1/5] ASoC: Remove -dai suffix from Samsung DAI devices

[Seungwhan Youn]

On Fri, Aug 13, 2010 at 5:59 PM, Mark Brown
<broonie at opensource.wolfsonmicro.com> wrote:
> On 13 Aug 2010, at 07:14, Joonyoung Shim wrote:
>> On 2010-08-13 오후 2:12, Seungwhan Youn wrote:
>>> On Thu, Aug 12, 2010 at 7:02 PM, Mark Brown
>
>>>> diff --git a/sound/soc/s3c24xx/aquila_wm8994.c b/sound/soc/s3c24xx/aquila_wm8994.c
>>>> index 44b06e9..235d197 100644
>>>> --- a/sound/soc/s3c24xx/aquila_wm8994.c
>>>> +++ b/sound/soc/s3c24xx/aquila_wm8994.c
>>>> @@ -233,7 +233,7 @@ static struct snd_soc_dai_link aquila_dai[] = {
>>>>  {
>>>>        .name = "WM8994",
>>>>        .stream_name = "WM8994 HiFi",
>>>> -       .cpu_dai_name = "s3c64xx-i2s-v4-dai",
>>>> +       .cpu_dai_name = "s3c64xx-i2s-v4",
>
>>> This aquila board also use I2Sv4 from 's3c64xx-i2s-v4.c', so I think
>>> it'll not work if cpu_dai_name is 's3c64xx-i2s-v4' not
>>> 's3c64xx-iis-v4'.
>
>> It confused me a little to use two names "iis" and "i2s". Can we unify to one?
>
> There's no change between -i2s and -iis introduced by this patch, all this patch did was strip the -dai suffix from the names. It looks like this is an error in the Aquilla driver which should be corrected.

I see. I just think that this patch modify to fix naming of i2s
platform driver with setting corresponding arm/arch like your
modification of 'smdk64xx_wm8580.c' in this patch. I think that aquila
board was wrong example, but I'm afraid that other boards which was
modified cpu_dai_name from Liam's multi-comp patches, also look
not-correct. Because I don't know they are using platform driver on
arch/arm, but I think that they(other machine code, like
jive_wm8750.c) use I2S driver named 's3c24xx-iis', 's3c2412-iis' and
's3c64xx-iis'.

Of course, that things can be handled another patch with another guy
who can verify its work. But, I think that fix on this patch will be
more nice to me.


I'm sorry, if I'm bothering you, and thank you for your comment,

Claude