[alsa-devel] [PATCH 1/2] ASoC: Set up debugfs only once per CODEC

[Peter Ujfalusi]

On Friday 13 August 2010 12:02:49 ext Mark Brown wrote:
> Sure, but the big problem there is that these aren't really CODEC
> specific objects.

Sure, but those widgets are directly connected to the CODEC's widgets.
And even if we have more than one codec under a single card, the widgets from 
the machine driver are kind of attached to the codec's chain (plus the 
interconnect routes between the multiple codecs if any).

> > > Since most of this stuff is actually for the card we should refactor
> > > but this can come later.
> > 
> > Sure, refactoring will help, but with this change we have missing debugfs
> > files for widgets, which is kind of confusing.
> 
> Meh, it's a debug facility and I hope it'll be sorted out within a week
> or so anyway.

Well, than it does not matter that much (the missing debugfs widget entries), 
if you have plans for this.

> Besides, you're not really loosing much information since
> there tends to be no interesting routing outside the CODEC.

Yeah. True. I have seen machines where there were some widgets of interest 
coming from the machine driver, but it is really only causes problems 
(inconvenience) with the debugfs.

Just wanted to mention the short term effect of this patch.

-- 
Péter