[alsa-devel] [PATCH] ISA: New Aztech Sound Galaxy driver

[Takashi Iwai]

At Wed, 11 Aug 2010 14:37:03 +0200,
René Herman wrote:
> 
> Hi Takashi.
> 
> I've dusted of the snd-galaxy Aztech Sound Galaxy driver that I posted 
> back in 2007. Have not been around for a long time but found some time 
> again currently. Earlier this year I was contacted about the driver so 
> there's still at least some demand for it.
> 
> It is the same version as posted way back then:
> 
> http://www.spinics.net/lists/alsa-devel/msg09791.html
> 
> only brought up to date to 2.6.35, and with lib.c folded back in to fix 
> the remaining problem from the earlier post.
> 
> It's also been tested again on all previously tested cards and two new 
> ones. Everything still found working. More information in the changelog 
> accompanying the patch below.
> 
> Cleaning up and moving AZT2320 to the galaxy directory as well would be 
> a next step, as would removing the old sgalaxy driver.
> 
> The patch has been generated against 2.6.35 and I've just now checked 
> that it applies cleanly to current git. Hope that'll do since I'm not 
> really setup to work against alsa-driver or anything. When updating the 
> driver I noticed fairly little seems to have happened inside sound/isa 
> anyway over the last few years, so I assumed it would be okay.
> 
> Hope it can be applied as is, but I have some time to deal with problems 
> currently.
> 
> @ Ram: Do you even still have the card? ;-)
> 
> Regards,
> Rene

Thanks, the patch looks almost OK, but checkpatch.pl complains some
minor things, and I think it's right (except for msleep).  Could you
fix them?

===
WARNING: Use #include <linux/io.h> instead of <asm/io.h>
#465: FILE: sound/isa/galaxy/galaxy.c:24:
+#include <asm/io.h>

WARNING: suspect code indent for conditional statements (16, 8)
#744: FILE: sound/isa/galaxy/galaxy.c:303:
+               if (dma1[n] == 0)
+       case 0:

WARNING: msleep < 20ms can sleep for up to 20ms; see
Documentation/timers/timers-howto.txt
+       msleep(10);
ERROR: space required after that ',' (ctx:VxV)
#1040: FILE: sound/isa/galaxy/galaxy.c:599:
+                       dev_err(dev, "no OPL device at%#lx\n",fm_port[n]);
                                                              ^

total: 1 errors, 3 warnings, 975 lines checked
===


Takashi