[alsa-devel] [PATCH v5 0/1] A codec driver for the TI WL1273 FM Radio.

[Liam Girdwood]

On Thu, 2010-08-05 at 13:43 +0300, Matti J. Aaltonen wrote:
> Hello.
> 
> New in the fifth version:
> 
> > > > +/* codec private data */
> > > > +struct wl1273_priv {
> > > > +   struct snd_soc_codec codec;
> > > > +   enum wl1273_mode mode;
> > > > +   struct wl1273_core *core;
> > > > +   unsigned int channels;
> > > > +};
> > > 
> > > ...why would anything outside the driver be peering into this?
> > 
> > Well, I see no reason... So I'll move it from the header to the c -file
> > and then it's fine?
> 
> OK... that's most probably what you mean. So I've moved the private
> struct definition from the header to the code file. And following the same
> logic I also moved the mode enum definition.
> 
> Cheers,
> Matti A.

This looks fine, although can you redo this against multi-component.
This should just involve changes to your probe() and remove().

Thanks

Liam 
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk