[alsa-devel] [PATCH] da7210: Fencepost error in reg cache read

Phil Carmody ext-phil.2.carmody at nokia.com
Wed Apr 14 16:03:13 CEST 2010


From: Phil Carmody <ext-phil.2.carmody at nokia.com>

An index equal to the array size may not be accessed.

Signed-off-by: Phil Carmody <ext-phil.2.carmody at nokia.com>
---
 sound/soc/codecs/da7210.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c
index 366daf1..96932a8 100644
--- a/sound/soc/codecs/da7210.c
+++ b/sound/soc/codecs/da7210.c
@@ -165,7 +165,7 @@ static const u8 da7210_reg[] = {
 static inline u32 da7210_read_reg_cache(struct snd_soc_codec *codec, u32 reg)
 {
 	u8 *cache = codec->reg_cache;
-	BUG_ON(reg > ARRAY_SIZE(da7210_reg));
+	BUG_ON(reg >= ARRAY_SIZE(da7210_reg));
 	return cache[reg];
 }
 
-- 
1.6.0.4



More information about the Alsa-devel mailing list