[alsa-devel] alsa-lib pcm_share.c snd_pcm_share_open() bug ?

[Jaroslav Kysela]

On Tue, 13 Apr 2010, Takashi Iwai wrote:

> At Fri, 9 Apr 2010 11:03:03 -0400,
> Mathieu Desnoyers wrote:
>>
>> Hi,
>>
>> I was looking at snd_pcm_share_open() in alsa-lib-1.0.22, and stumbled on the
>> following line:
>>
>>         pcm->monotonic = pcm->monotonic;
>>
>> what is that supposed to do ? There is clearly something wrong there.
>
> Yeah, very fishy here.
>
> I suppose this plugin can't handle monotonic time as is.
> Jaroslav, could you fix that?

The plugin can handle the monotonic clock as well. The correct line should 
be:

 	pcm->monotonic = slave->pcm->monotonic;

Mathieu - thanks for notice.

 					Jaroslav

-----
Jaroslav Kysela <perex at perex.cz>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.