[alsa-devel] [PATCHv2 7/7] ASoC: TWL6030: Power-up seq completion through audio interrupt

[Mark Brown]

On Fri, Sep 25, 2009 at 09:03:45PM -0500, Lopez Cruz, Misael wrote:

> -	0x41, /* TWL6030_INTMR		0x04	*/
> +	0x00, /* TWL6030_INTMR		0x04	*/

I suspect this should've been in the previous patch.

> -			/* power-up sequence latency */
> -			mdelay(16);
> +			/* wait for ready interrupt */
> +			wait_for_completion(&priv->ready_completion);

You should provide a timeout here, otherwise if there's a hardware
problem the driver will hang indefinitately waiting for the IRQ.