[alsa-devel] [PATCH 1/3] [ALSA] Add quirk for Sony Vaio VGN-SZ650N

[Takashi Iwai]

At Mon, 28 Sep 2009 11:43:11 +0200,
Pascal Terjan wrote:
> 
> From
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/195605/comments/25
> 
> Signed-off-by: Pascal Terjan <pterjan at mandriva.com>

Thanks for the patch.
I think we can merge all three using SND_PCI_QUIRK_MASK(), e.g.
SND_PCI_QUIRK_MASK(0x104d, 0xff00, 0x9000, "Sony VAIO", STAC_9872_VAIO)

Or, a bit safer like
SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9000, "Sony VAIO", STAC_9872_VAIO)
SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x9010, "Sony VAIO", STAC_9872_VAIO)

Could you check whether it's OK?

Also, please make sure that this change is really needed for the
latest alsa-driver.  The recent version probes the BIOS setup, and
it should work as is unless BIOS is broken.  The quirk entries like
the above override the BIOS setup, thus should be used only when
really needed.


thanks,

Takashi

> ---
>  sound/pci/hda/patch_sigmatel.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
> index 826137e..cd91d95 100644
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -5815,6 +5815,8 @@ static unsigned int *stac9872_brd_tbl[STAC_9872_MODELS] = {
>  static struct snd_pci_quirk stac9872_cfg_tbl[] = {
>  	SND_PCI_QUIRK_MASK(0x104d, 0xfff0, 0x81e0,
>  			   "Sony VAIO F/S", STAC_9872_VAIO),
> +	SND_PCI_QUIRK(0x104d, 0x9008,
> +			   "Sony Vaio VGN-SZ650N", STAC_9872_VAIO),
>  	{} /* terminator */
>  };
>  
> -- 
> 1.6.4.2
>