[alsa-devel] [PATCH 2/6] ak4620 support, moving the proc codec regs entry to ak4xxx-adda,

[Takashi Iwai]

At Tue, 15 Sep 2009 00:44:59 +0200,
pavel.hofman at ivitera.com wrote:
> 
> @@ -627,7 +660,7 @@ static int build_dac_controls(struct snd_akm4xxx *ak)
>  		memset(&knew, 0, sizeof(knew));
>  		if (! ak->dac_info || ! ak->dac_info[mixer_ch].name) {
>  			knew.name = "DAC Volume";
> -			knew.index = mixer_ch + ak->idx_offset * 2;
> +		knew.index = mixer_ch + ak->idx_offset * 2;

Looks like a wrong indent.

> @@ -738,6 +779,7 @@ static int build_adc_controls(struct snd_akm4xxx *ak)
>  				AK_VOL_CVT | AK_IPGA;
>  		else
>  			knew.private_value =
> +/* TODO - opravdu 163? Datasheet rika 165 */

In English please :)

> @@ -834,6 +877,31 @@ static int build_deemphasis(struct snd_akm4xxx *ak, int num_emphs)
>  	return 0;
>  }
>  
> +static void proc_regs_read(struct snd_info_entry *entry,
> +		struct snd_info_buffer *buffer)
> +{

Please put #ifdef CONFIG_PROC_FS around the proc interface.
Although the compiler will optimize out (and I know the old code did
so), it won't cut all codes but some unnecessary bytes still remain.

>  int snd_akm4xxx_build_controls(struct snd_akm4xxx *ak)
>  {
>  	int err, num_emphs;
> @@ -845,14 +913,19 @@ int snd_akm4xxx_build_controls(struct snd_akm4xxx *ak)
>  	err = build_adc_controls(ak);
>  	if (err < 0)
>  		return err;
> -
>  	if (ak->type == SND_AK4355 || ak->type == SND_AK4358)
>  		num_emphs = 1;
> +	/* PAVEL */

This comment isn't so meaningful :)
The changes can be tracked better in GIT, anyway.


thanks,

Takashi