[alsa-devel] Patch for au88x0 driver. Fix audacious issue and add auto reset in case of hardware ADB ctrl failure.

[Takashi Iwai]

At Fri, 04 Sep 2009 11:27:51 +0200,
Daniel Glöckner wrote:
> 
> On 09/03/2009 10:10 PM, Manuel Jander wrote:
> > does anybody still have a AU88x0 card ? I know they are quite ancient
> > now, but if anyone could give the attached patch a try ? Would be
> > nice.
> 
> I can test an AU8820 on 2.4.37 and, if you wait >9 days, an AU8810 on a recent
> kernel, but what is this hunk supposed to do?:
> 
> --- linux-2.6.30.4_orig/sound/pci/au88x0/au88x0_core.c  2009-07-31 00:34:47.0000
> 00000 +0200
> +++ linux-2.6.30.4/sound/pci/au88x0/au88x0_core.c       2009-09-02 00:13:59.4671
> 19172 +0200
> @@ -2800,7 +2804,7 @@
>  {
>  	int a, this_194;
> 
> -	if ((bits != 8) && (bits != 16))
> +	if ((bits != 8) || (bits != 16))
>  		return -1;
> 
>  	switch (encod) {

This reverts the upstream fix in commit
83807400794a1d680a4fb70a610c5f486e734f45.
I guess Manuel just overlooked this upstream fix.


Takashi