[alsa-devel] [PATCH 2/3] ASoC: DaVinci: pcm, rename variables in prep for ping/pong

David Brownell david-b at pacbell.net
Thu Sep 3 21:06:20 CEST 2009


On Monday 31 August 2009, Troy Kisky wrote:
> -       int master_lch;         /* Master DMA channel */
> -       int slave_lch;          /* linked parameter RAM reload slot */
> +       int asp_master_lch;     /* Master DMA channel */
> +       int asp_link_lch[2];    /* asp parameter link channel, ping/pong */

If you're going to rename things, may I suggest getting
rid of "lch" ... use either "channel" or "link", since
those are the two basic hardware roles in EDMA.

The original "lch" ("logical channel") terminology was
an IMO misguded attempt to hide the distinction between
channels and links.  But links can not be used when a
channel is required, so that attempt was doomed to fail.
(Channels could double as links, but as a rule that's
not done since they're relatively scarce.)

- Dave




More information about the Alsa-devel mailing list