[alsa-devel] [PATCH] OMAP: McBSP: Do not use extensive spin locks for dma_op_mode

Peter Ujfalusi peter.ujfalusi at nokia.com
Tue Oct 27 13:04:31 CET 2009


On Tuesday 27 October 2009 14:00:09 ext Mark Brown wrote:
> 
> I have to confess that I'm still not entirely clear what the lock is
> supposed to be doing or why it's OK to drop it.  I gather that it's just
> that dmap_on_mode() doesn't need a lock at all?

In my opinion it does not need a lock.
If the user space is so broken that it is doing different things in parallel, I 
would rather crash the kernel if it is possible to force someone to fix the mess 
upstairs.
But the lock is not needed, I think it was a result of over-engineering.


-- 
Péter


More information about the Alsa-devel mailing list