[alsa-devel] [patch] snd-pcsp: fix nforce_wa

Stas Sergeev stsp at aknet.ru
Sat Oct 17 18:27:35 CEST 2009


Hi.

In this commit:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=eea0579fc85e64e9f05361d5aacf496fe7a151aa
the nforce workaround (nforce_wa
option) was broken, because the
introduced "pointer_update" variable
was forgotten to use.
Also, the "ns" became u64 in some
places and "long" in others, which
is not the same, AFAIK. I revert that
to u64-everywhere.
Also, the log says:
---
With the callback mode HRTIMER_CB_IRQSAFE_UNLOCK, the start of the
stream with zero delay doesn't work.
---
but the attached patch, that reverts
to the "zero-delay start", works for
me... So, while I like the cleanups
made, I wonder what was the reason
behind that changes? How can I reproduce
the breakage of the zero-delay start?
Oh, and it would be nice to CC me the
changes in that driver, if possible. :)
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pcsp_nfwa.diff
Url: http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20091017/11cb8bad/attachment-0001.bat 


More information about the Alsa-devel mailing list