[alsa-devel] sscape: make more code __devinit and other improvements

[Takashi Iwai]

At 08 Oct 2009 09:01:39 +0200,
krzysztof.h1 at poczta.fm wrote:
> 
> "Takashi Iwai" <tiwai at suse.de> pisze:
> > At Wed, 7 Oct 2009 18:45:37 +0200,
> > Krzysztof Helt wrote:
> > > 
> > > From: Krzysztof Helt <krzysztof.h1 at wp.pl>
> > > 
> > > Make code to upload firmware marked as __devinit.
> > 
> > I guess the mark would be removed again if you implement suspend/resume
> > :)
> > If you are not going to implement PM, I'm willing to apply this patch,
> > though.
> > 
> 
> I haven't thought about this. Drop the patch then.

OK.  If you'll work on this further, could you split the patches?
One for coding style fixes, and one for clean up, and other for the
rest (if any).

> > > General code and coding style improvements.
> > > 
> > > Add a missing argument for CMD_XXX_MIDI_VOL command.
> > > 
> > > Signed-off-by: Krzysztof Helt <krzysztof.h1 at wp.pl>
> > > ---
> > > This is the last my patch for the sscape driver.
> > > 
> > > I will examine if the OSS aedsp16 driver can be removed as well. The
> > corresponding 
> > > ALSA driver is snd-sc6000.
> > 
> > Yeah, that'll be nice.
> > 
> > 
> 
> I have a strange problem. The sscape and aedsp16 drivers do not work
> correctly with OSS drivers (DMA/IRQ problem) but they work correctly
> with ALSA + OSS emulation. I will check more cards (e.g. SB16). It
> may a new bug in the OSS layer.

Do you mean "OSS layer" = OSS drivers, not as OSS emulation?

thanks,

Takashi