[alsa-devel] [PATCH 1/31] HDA patch_via.c: Remove IS_VT17xx_VENDORID macro

[Li Bo]

On Thu, Oct 8, 2009 at 2:27 PM, Takashi Iwai <tiwai at suse.de> wrote:
> At Thu, 8 Oct 2009 14:22:07 +0800,
> Li Bo wrote:
>>
>> On Thu, Oct 8, 2009 at 2:16 PM, Takashi Iwai <tiwai at suse.de> wrote:
>> > At Thu, 8 Oct 2009 14:11:42 +0800,
>> > Li Bo wrote:
>> >>
>> >> On Thu, Oct 8, 2009 at 2:03 PM, Takashi Iwai <tiwai at suse.de> wrote:
>> >> > At Thu, 8 Oct 2009 13:27:49 +0800,
>> >> > Li Bo wrote:
>> >> >>
>> >> >> [ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro
>> >> >>
>> >> >> IS_VT17*_VENDORID macros are used nowhere, so clean them up.
>> >> >>
>> >> >> Signed-off-by: Lydia Wang <lydiawang at viatech.com.cn>
>> >> >
>> >> > Li, could you add your sign-off, too, when you handle the patches?
>> >> > Otherwise I can't merge them.
>> >> >
>> >> >
>> >> > thanks,
>> >> >
>> >> > Takashi
>> >> >
>> >>
>> >> Is that OK signed-off with LoganLi at viatech.com.cn with this gmail
>> >> liboat at gamil.com? LoganLi at viatech.com.cn is my company's email.
>> >> If not, I'll will resend them tomorrow when I go back to company.
>> >
>> > I don't care which address you use (and I don't know whether it
>> > matters your employer).  It's fully your choice.
>> >
>> > But, if the signed address is different from the mail sender, add a
>> > line "From: YOUR NAME <your at mail>" at the beginning of the patch
>> > explicitly.
>> >
>> >
>> > thanks,
>> >
>> > Takashi
>> >
>> I just randomly use my gmail. I will resend them tomorrow, thank you for
>> teaching me:)
>
> Well, I was unclear in the text above.
>
> You can send patches with the sign-off of your company account even
> from your gmail account.  Just add "From:" line with your company
> account in the patch text so that I can pick up the right address.
>
>
> Takashi
>
like this?
[ALSA] HDA VIA: Remove unused IS_VT17xx_VENDORID macro

IS_VT17*_VENDORID macros are used nowhere, so clean them up.

Signed-off-by: Lydia Wang <lydiawang at viatech.com.cn>
Signed-off-by: Logan Li <loganli at viatech.com.cn>
From: Li Bo <liboat at gmail.com>

---
 sound/pci/hda/patch_via.c |    8 --------
 1 file changed, 8 deletions(-)

--- a/sound/pci/hda/patch_via.c
+++ b/sound/pci/hda/patch_via.c
@@ -76,14 +76,6 @@
 #define VT1702_HP_NID		0x17
 #define VT1702_DIGOUT_NID	0x11

-#define IS_VT1708_VENDORID(x)		((x) >= 0x11061708 && (x) <= 0x1106170b)
-#define IS_VT1709_10CH_VENDORID(x)	((x) >= 0x1106e710 && (x) <= 0x1106e713)
-#define IS_VT1709_6CH_VENDORID(x)	((x) >= 0x1106e714 && (x) <= 0x1106e717)
-#define IS_VT1708B_8CH_VENDORID(x)	((x) >= 0x1106e720 && (x) <= 0x1106e723)
-#define IS_VT1708B_4CH_VENDORID(x)	((x) >= 0x1106e724 && (x) <= 0x1106e727)
-#define IS_VT1708S_VENDORID(x)		((x) >= 0x11060397 && (x) <= 0x11067397)
-#define IS_VT1702_VENDORID(x)		((x) >= 0x11060398 && (x) <= 0x11067398)
-
 enum VIA_HDA_CODEC {
 	UNKNOWN = -1,
 	VT1708,